Wireshark-commits: [Wireshark-commits] master-3.0 c500ad4: TLS: report encrypted TLS alerts as such
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 05 Nov 2019 13:40:31 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c500ad4f720be2017d942d564b84414f30186d22
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

c500ad4 by Peter Wu (peter@xxxxxxxxxxxxx):

    TLS: report encrypted TLS alerts as such
    
    Encrypted alerts could be misreported as plain encrypt messages. Be sure
    to check the length before interpreting it as unencrypted alert message.
    Rename SSL to TLS while at it, and support unknown alerts.
    
    Bug: 16180
    Change-Id: I223568f8502cd629fed4642a786c9f5fcb488e8e
    Reviewed-on: https://code.wireshark.org/review/34982
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 3ccb01666bb1c4f0fad79472cf7626d3ce0eb77e)
    Reviewed-on: https://code.wireshark.org/review/34983
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  51fea6d   rtp_analysis_dialog.cpp: Correct src/dst info for two independent streams
     add  c500ad4   TLS: report encrypted TLS alerts as such


Summary of changes:
 epan/dissectors/packet-tls.c | 65 ++++++++++++++++++++------------------------
 1 file changed, 30 insertions(+), 35 deletions(-)