Wireshark-commits: [Wireshark-commits] master 3ccb016: TLS: report encrypted TLS alerts as such
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 05 Nov 2019 13:28:24 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3ccb01666bb1c4f0fad79472cf7626d3ce0eb77e
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

3ccb016 by Peter Wu (peter@xxxxxxxxxxxxx):

    TLS: report encrypted TLS alerts as such
    
    Encrypted alerts could be misreported as plain encrypt messages. Be sure
    to check the length before interpreting it as unencrypted alert message.
    Rename SSL to TLS while at it, and support unknown alerts.
    
    Bug: 16180
    Change-Id: I223568f8502cd629fed4642a786c9f5fcb488e8e
    Reviewed-on: https://code.wireshark.org/review/34982
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  2ce3ec5   PROFINET: Padding in SRLData block is corrected.
     add  3ccb016   TLS: report encrypted TLS alerts as such


Summary of changes:
 epan/dissectors/packet-tls.c | 65 ++++++++++++++++++++------------------------
 1 file changed, 30 insertions(+), 35 deletions(-)