Wireshark-commits: [Wireshark-commits] master-2.6 801b9b8: Qt: Prevent crash in main window layout.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 15 Sep 2019 06:05:23 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=801b9b8982660a1a926bc3ac94d4f999dc93c601
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

801b9b8 by Evan Welsh (noreply@xxxxxxxxxxxxx):

    Qt: Prevent crash in main window layout.
    
    Add length check for extra_sizes array in geometry calculations when using
    recent  sizes, prevents crash in case where user creates a new user profile
    with a layout of 1) filled pane 2) empty pane 3) empty pane.
    
    Bug: 16048
    Change-Id: I5f30d6e4148703504029efab75a77f2cdb6619ff
    Reviewed-on: https://code.wireshark.org/review/34524
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (backported from commit c0224eeeb833c3ee0b2625c71b9915f13afadb23)
    Reviewed-on: https://code.wireshark.org/review/34528
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  fa4f4bf   randpktdump: Initialize print error handler
     add  801b9b8   Qt: Prevent crash in main window layout.


Summary of changes:
 ui/qt/main_window_slots.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)