Wireshark-commits: [Wireshark-commits] master-3.0 021d581: Qt: Prevent crash in main window layout.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 15 Sep 2019 03:59:23 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=021d581e9a94096448f7f383664cac9d9c4f8241
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

021d581 by Evan Welsh (noreply@xxxxxxxxxxxxx):

    Qt: Prevent crash in main window layout.
    
    Add length check for extra_sizes array in geometry calculations when using
    recent  sizes, prevents crash in case where user creates a new user profile
    with a layout of 1) filled pane 2) empty pane 3) empty pane.
    
    Bug: 16048
    Change-Id: I5f30d6e4148703504029efab75a77f2cdb6619ff
    Reviewed-on: https://code.wireshark.org/review/34524
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit c0224eeeb833c3ee0b2625c71b9915f13afadb23)
    Reviewed-on: https://code.wireshark.org/review/34527
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  c9bfeb2   randpktdump: Initialize print error handler
     add  021d581   Qt: Prevent crash in main window layout.


Summary of changes:
 ui/qt/main_window_layout.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)