Wireshark-commits: [Wireshark-commits] master c0224ee: Qt: Prevent crash in main window layout.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 14 Sep 2019 20:34:59 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c0224eeeb833c3ee0b2625c71b9915f13afadb23
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

c0224ee by Evan Welsh (noreply@xxxxxxxxxxxxx):

    Qt: Prevent crash in main window layout.
    
    Add length check for extra_sizes array in geometry calculations when using
    recent  sizes, prevents crash in case where user creates a new user profile
    with a layout of 1) filled pane 2) empty pane 3) empty pane.
    
    Bug: 16048
    Change-Id: I5f30d6e4148703504029efab75a77f2cdb6619ff
    Reviewed-on: https://code.wireshark.org/review/34524
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  43c053e   BACnet: Wrong dissection device identifier
     add  c0224ee   Qt: Prevent crash in main window layout.


Summary of changes:
 ui/qt/main_window_layout.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)