Wireshark-commits: [Wireshark-commits] master-3.0 9541420: SNMP: handle Net-SNMP Engine Id of 12 oc
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 14 Sep 2019 19:56:10 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9541420798124ee50e5da9be6307d50bf4509b95
Submitter: "Michael Mann <mmann78@xxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

9541420 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    SNMP: handle Net-SNMP Engine Id of 12 octets
    
    The Net-SNMP code creates an Engine Id size based on the compilation
    size, either 8 or 12 octets long. Current implementation handles 32 bit
    compilation of Net-SNMP (resulting in 8 octets), this change adds
    handling of 64 bit compilation of Net-SNMP (resulting in 12 octets).
    
    Bug: 16051
    Change-Id: I256f9a7ad2fd219492e4ebc413ef24cd2c210e0b
    Reviewed-on: https://code.wireshark.org/review/34520
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit 608dbda8eeefeb1c79fd93c1848515d8bc6b4ca1)
    Reviewed-on: https://code.wireshark.org/review/34522
    

Actions performed:

    from  a1dd797   Release notes: The Windows installers ship with Qt 5.12.5.
     add  9541420   SNMP: handle Net-SNMP Engine Id of 12 octets


Summary of changes:
 epan/dissectors/asn1/snmp/packet-snmp-template.c | 12 ++++++------
 epan/dissectors/packet-snmp.c                    | 12 ++++++------
 2 files changed, 12 insertions(+), 12 deletions(-)