Wireshark-commits: [Wireshark-commits] master-2.6 d91e7e5: Wiretap: Write commview files with valid
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 04 Sep 2019 20:18:59 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d91e7e57fbc5b9c379e3f1e23461b05a7486c96a
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

d91e7e5 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    Wiretap: Write commview files with valid headers
    
    When writing a capture as a commview file the header written is two
    bytes longer than the specification. Even though we count 24, we
    actually write 26. This makes the commview file corrupt, as is apparent
    when reading such file, eg., after using Save As... with this format.
    
    Replace writing 2 bytes for the last two fields in the header by 1 byte
    each, as per the header specification.
    
    Change-Id: I9436f7837b2e3617a389619884bf93ad146e95f3
    Reviewed-on: https://code.wireshark.org/review/34450
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit d58f8f57c110254a72b3329c457e748830808667)
    Reviewed-on: https://code.wireshark.org/review/34453
    

Actions performed:

    from  45f6b40   What we're testing for is byte-swappedness, not raw endianness.
     add  d91e7e5   Wiretap: Write commview files with valid headers


Summary of changes:
 wiretap/commview.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)