Wireshark-commits: [Wireshark-commits] master-3.0 8e4d72d: Wiretap: Write commview files with valid
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 04 Sep 2019 20:18:45 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8e4d72d0b629fc5e1a4c0232747106667a4fc124
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

8e4d72d by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    Wiretap: Write commview files with valid headers
    
    When writing a capture as a commview file the header written is two
    bytes longer than the specification. Even though we count 24, we
    actually write 26. This makes the commview file corrupt, as is apparent
    when reading such file, eg., after using Save As... with this format.
    
    Replace writing 2 bytes for the last two fields in the header by 1 byte
    each, as per the header specification.
    
    Change-Id: I9436f7837b2e3617a389619884bf93ad146e95f3
    Reviewed-on: https://code.wireshark.org/review/34450
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 35062c2bdd57ef865431a837e513691bb20e50ce)
    Reviewed-on: https://code.wireshark.org/review/34452
    

Actions performed:

    from  5ab732f   What we're testing for is byte-swappedness, not raw endianness.
     add  8e4d72d   Wiretap: Write commview files with valid headers


Summary of changes:
 wiretap/commview.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)