Wireshark-commits: [Wireshark-commits] master cae3bec: Qt: Remove global recent_ctx_menu
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 31 Jul 2019 07:49:49 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cae3bec14e4bc56ce95875f4b9d1c6f70e7f5a7e
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

cae3bec by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Remove global recent_ctx_menu
    
    Make recent_ctx_menu local to showRecentContextMenu() to avoid
    keeping a global pointer which needs to be cleared every time.
    
    Change-Id: Ic3baae4501e00ee753529b1edd5888de5d1e2167
    Reviewed-on: https://code.wireshark.org/review/34142
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  927afac   Qt: Check for NULL pointer in profile->reference
     add  cae3bec   Qt: Remove global recent_ctx_menu


Summary of changes:
 ui/qt/welcome_page.cpp | 13 ++++++-------
 ui/qt/welcome_page.h   |  3 ---
 2 files changed, 6 insertions(+), 10 deletions(-)