Wireshark · Wireshark-commits: [Wireshark-commits] master 927afac: Qt: Check for NULL pointer in profile->reference

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=927afac57082d8703ffd39e293f2511adcac7644
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

927afac by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Check for NULL pointer in profile->reference
    
    Check for NULL pointer before using profile->reference in strcmp()
    because this will give a crash. Doing a copy profile from a new profile
    will set the reference to NULL in get_profile_parent().
    
    Use an unambiguously profile reference value NULL as profile->reference
    when creating a new profile to align with when copy from a new profile.
    
    Change-Id: Ib27a1a309776e9c2ec44677f2d22f9a5635dd38a
    Reviewed-on: https://code.wireshark.org/review/34137
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  5d0a2cc   Qt: Change from User/System to Personal/Global profile types
     add  927afac   Qt: Check for NULL pointer in profile->reference


Summary of changes:
 ui/qt/models/profile_model.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)