Wireshark-commits: [Wireshark-commits] master ce1adf9: Don't just grab raw string data with tvb_mem
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 16 Jul 2019 23:34:38 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ce1adf9862709c1b3d77b14bfac20626e5c5f723
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

ce1adf9 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't just grab raw string data with tvb_memcpy().
    
    Use proto_tree_add_item_ret_display_string() routines to add strings if
    we want to display the string's value in a column.  That way, all
    strings are fetched using an encoding value, to properly map to UTF-8,
    and are formatted for display.
    
    Change-Id: I4acd9ed7cfad3342be84a4773187dd531949f47b
    Reviewed-on: https://code.wireshark.org/review/33974
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  d699c5d   Clean up handling of the command parameter.
     add  ce1adf9   Don't just grab raw string data with tvb_memcpy().


Summary of changes:
 epan/dissectors/packet-distcc.c | 46 ++++++++++++++++++++---------------------
 1 file changed, 23 insertions(+), 23 deletions(-)