Wireshark-commits: [Wireshark-commits] master d699c5d: Clean up handling of the command parameter.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 16 Jul 2019 22:48:26 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d699c5d84c498b4a853b64ff2826ff5504eaf096
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

d699c5d by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up handling of the command parameter.
    
    It's an unsigned int, as per the protocol spec.  Treat it as such.  (Add
    a URL for the protocol spec while we're at it.)
    
    Convert it from a string of ASCII hex digits to a number using
    ws_hexstrtou32(); that routine does the appropriate checks.
    
    Clean up blank lines while we're at it - add some and remove some.
    
    Change-Id: I2c0832c4a57c121e2e64de49a8678b747025f35e
    Reviewed-on: https://code.wireshark.org/review/33972
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  a754879   X2AP: upgrade dissector to v15.6.0
     add  d699c5d   Clean up handling of the command parameter.


Summary of changes:
 epan/dissectors/packet-distcc.c | 71 ++++++++++++++++++++---------------------
 1 file changed, 35 insertions(+), 36 deletions(-)