Wireshark-commits: [Wireshark-commits] master e891f57: Qt: remove CaptureFile from CredentialsModel
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 04 Jul 2019 12:56:30 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e891f57bb3a87c77a021ab9e69e45a813e9ff241
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

e891f57 by Dario Lombardo (lomato@xxxxxxxxx):

    Qt: remove CaptureFile from CredentialsModel constructor.
    
    Unused:
    
    [55/83] Building CXX object ui/qt/CMakeFiles/qtui.dir/models/credentials_model.cpp.o
    /Users/stig/Development/wireshark/ui/qt/models/credentials_model.cpp:18:66: warning: unused parameter 'cf' [-Wunused-parameter]
    CredentialsModel::CredentialsModel(QObject *parent, CaptureFile& cf)
                                                                     ^
    1 warning generated.
    
    Change-Id: I8f89a8121c55bae3fdc5d317beb5a87e0135f02a
    Reviewed-on: https://code.wireshark.org/review/33841
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  ca4b950   Qt: Workaround for Qt model() bug
     add  e891f57   Qt: remove CaptureFile from CredentialsModel constructor.


Summary of changes:
 ui/qt/credentials_dialog.cpp       | 2 +-
 ui/qt/models/credentials_model.cpp | 2 +-
 ui/qt/models/credentials_model.h   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)