Wireshark-commits: [Wireshark-commits] master ca4b950: Qt: Workaround for Qt model() bug
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 04 Jul 2019 11:13:00 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ca4b950bfa986b4f7b963a772be03ab2aff653e7
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

ca4b950 by Roland Knall (rknall@xxxxxxxxx):

    Qt: Workaround for Qt model() bug
    
    model() on the TreeView should return a value, but instead returns a null
    pointer. Moving the methods to the model would be the next step, but until
    then, this workaround regains functionality
    
    Change-Id: Iaa0b6470af41b297a821c0dd6e3a238481752886
    Reviewed-on: https://code.wireshark.org/review/33839
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  66e92e7   Qt: Do not export the model of the packetlist
     add  ca4b950   Qt: Workaround for Qt model() bug


Summary of changes:
 ui/qt/packet_list.cpp | 20 ++++++++------------
 ui/qt/packet_list.h   |  2 +-
 2 files changed, 9 insertions(+), 13 deletions(-)