Wireshark-commits: [Wireshark-commits] master 4dbb26f: GBCS: Increment offset before subtracting le
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 28 Jan 2019 06:14:06 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4dbb26fdb8de6bc634c0d405a57b803bf2815c1d
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

4dbb26f by Martin Boye Petersen (martinboyepetersen@xxxxxxxxx):

    GBCS: Increment offset before subtracting length
    
    Fixed issue with incorrect item end being set for the
    grouping header if it includes a KA certificate.
    Length was subtracted first (set to 0) and therefor the
    offset would remain unchanged.
    
    Change-Id: I23ab1620613af821ee5a41fc29b83e6d4b08430e
    Reviewed-on: https://code.wireshark.org/review/31764
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  58861b0   TDS: Fix colmetadata handling of Text and Image types
     add  4dbb26f   GBCS: Increment offset before subtracting length


Summary of changes:
 epan/dissectors/packet-gbcs.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)