Wireshark-commits: [Wireshark-commits] master 58861b0: TDS: Fix colmetadata handling of Text and Im
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 28 Jan 2019 05:01:14 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=58861b07ee7026038753222c9e878f32114d2059
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

58861b0 by Craig Jackson (cejackson51@xxxxxxxxx):

    TDS: Fix colmetadata handling of Text and Image types
    
    The Colmetadata handling for TEXT, NTEXT, and IMAGE types was incorrect for
    TDS 7 versions before TDS 7.2. In addition, the macros using for testing
    versions were incorrect.
    
    Clean up max length display to agree with Microsoft specification (as best
    as I can understand it).
    
    Bug: 3098
    Change-Id: I8254649fd3de97c103078ceaac1557fde3569ded
    Reviewed-on: https://code.wireshark.org/review/31734
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  09ea924   opa-mad: Fixed bfrctrl and portinfo multiblock padding
     add  58861b0   TDS: Fix colmetadata handling of Text and Image types


Summary of changes:
 docbook/release-notes.asciidoc |   2 +
 epan/dissectors/packet-tds.c   | 128 +++++++++++++++++++++++------------------
 2 files changed, 73 insertions(+), 57 deletions(-)