Wireshark-commits: [Wireshark-commits] master 5cc4614: CMake: use object libraries to avoid redunda
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 12 Jan 2019 18:20:51 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5cc461490d817be898629562b947099a9996f198
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

5cc4614 by Peter Wu (peter@xxxxxxxxxxxxx):

    CMake: use object libraries to avoid redundant builds
    
    Some source files are duplicated via add_executable. Assuming that these
    are not affected by target-specific preprocessor macros, they can be
    built only once and shared among executables.
    
    In one configuration, this reduces the number of object files by 55
    (cli_main.c and version_info.c alone were built 15 times each).
    
    Removes the version dependency from each target since the 'version_info'
    target can now declare this dependency. Remove CLEAN_C_FILES from extcap
    since it is not used to set -Werror. Due to removing some files from
    wireshark_FILES (and others), these are no longer part of checkAPIs
    though. Hopefully that is acceptable.
    
    Change-Id: I0a3f1ffb950e70a6176c96d867f694fbc6476f58
    Reviewed-on: https://code.wireshark.org/review/31509
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: João Valverde <j@xxxxxx>
    Petri-Dish: João Valverde <j@xxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  6d08cb2   CMake: Fix inconsistent find_package() report output
     add  5cc4614   CMake: use object libraries to avoid redundant builds


Summary of changes:
 .gitignore             |   2 -
 CMakeLists.txt         | 108 +++++++++++++++++++++++++------------------------
 epan/CMakeLists.txt    |   4 +-
 extcap/CMakeLists.txt  |  51 ++++++++++++++---------
 fuzz/CMakeLists.txt    |   3 +-
 wiretap/CMakeLists.txt |   4 +-
 6 files changed, 89 insertions(+), 83 deletions(-)