Wireshark-commits: [Wireshark-commits] master 6d08cb2: CMake: Fix inconsistent find_package() repor
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 12 Jan 2019 18:17:06 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6d08cb2ecd51dceefb49ff65532e0ca4de4ad417
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

6d08cb2 by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):

    CMake: Fix inconsistent find_package() report output
    
    Most CMake find modules report the binary found, the modules
    fixed by this change represent an inconsistent exception.
    
    The first REQUIRED_VAR argument to
    find_package_handle_standard_args() is the one used by CMake
    to report on the result of find_package().
    
    Compare (master)
      -- Found SNAPPY: /usr/include
    to (this change)
      -- Found SNAPPY: /usr/lib/x86_64-linux-gnu/libsnappy.so
    
    This convention of using XXX_LIBRARY matches upstream practice.
    
    Change-Id: Iaa0ec644e963430d73722354f6ee2a3694906ba7
    Reviewed-on: https://code.wireshark.org/review/31498
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  16953ec   CMake: Remove legacy workaround for GTK+Zlib
     add  6d08cb2   CMake: Fix inconsistent find_package() report output


Summary of changes:
 cmake/modules/FindAIRPCAP.cmake | 2 +-
 cmake/modules/FindBCG729.cmake  | 2 +-
 cmake/modules/FindLZ4.cmake     | 2 +-
 cmake/modules/FindNGHTTP2.cmake | 2 +-
 cmake/modules/FindPCAP.cmake    | 2 +-
 cmake/modules/FindSBC.cmake     | 2 +-
 cmake/modules/FindSNAPPY.cmake  | 2 +-
 cmake/modules/FindSPANDSP.cmake | 2 +-
 cmake/modules/FindSystemd.cmake | 2 +-
 9 files changed, 9 insertions(+), 9 deletions(-)