Wireshark-commits: [Wireshark-commits] master 8915dea: CMake: Workaround for broken install target
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 25 Nov 2018 03:02:57 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8915deaef33faaf0a2acf675054a03af5c0ba321
Submitter: "João Valverde <j@xxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

8915dea by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):

    CMake: Workaround for broken install target on Windows (help)
    
    The installation step cannot depend on CMAKE_CFG_INTDIR.
    This step is executed in a cmake script without the build
    tool so variables like $(Configuration) of Visual Studio
    don't get substituted, breaking the installation.
    
    Ping-Bug: 15301
    Change-Id: Idc0c48b6dc440ad1d9b2d6a2824cc89190997b60
    Reviewed-on: https://code.wireshark.org/review/30784
    Reviewed-by: João Valverde <j@xxxxxx>
    

Actions performed:

    from  6bc9a88   Remove a stale FIXME
     add  8915dea   CMake: Workaround for broken install target on Windows (help)


Summary of changes:
 CMakeLists.txt | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)