Wireshark-commits: [Wireshark-commits] master 6bc9a88: Remove a stale FIXME
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 25 Nov 2018 01:42:37 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6bc9a88ee8f2c35eef12ff50716378b5e6091bb0
Submitter: "João Valverde <j@xxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

6bc9a88 by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):

    Remove a stale FIXME
    
    While at it prefer to use add_definitions() instead of config.h. This
    puts all definitions in the same place and limits the scope to the
    respective wsutil API.
    
    Change-Id: Idc30914220b876865e0ae47709e6f17eb9b0fc2c
    Reviewed-on: https://code.wireshark.org/review/30782
    Petri-Dish: João Valverde <j@xxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: João Valverde <j@xxxxxx>
    

Actions performed:

    from  65c13f9   Install development headers on all platforms
     add  6bc9a88   Remove a stale FIXME


Summary of changes:
 cmakeconfig.h.in      | 4 ----
 wsutil/CMakeLists.txt | 1 +
 2 files changed, 1 insertion(+), 4 deletions(-)