Wireshark-commits: [Wireshark-commits] master 184b943: QUIC: fully fix random access decryption, im
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 21 Mar 2018 16:57:46 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=184b943fbd4c113998419ed377f81aad0e2f43b9
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

184b943 by Peter Wu (peter@xxxxxxxxxxxxx):

    QUIC: fully fix random access decryption, improve error messages
    
    When a conversation contains two Initial Packet messages or payloads
    spanning key updates, then the cipher might be unusable when trying to
    decrypt an earlier packet. To solve this, perform decryption on the
    first pass only and store the result (error message and plaintext).
    
    Display an error message when payload decryption is not possible due to
    missing keys (currently, TLS Exporter secrets from the TLS key log).
    
    Refactor code for adding decrypted results/expert info to reduce code
    duplication and have less ifdef's.
    
    Bug: 13881
    Change-Id: I932069b09840e14c7ccc6a235f62b8830f1b85aa
    Reviewed-on: https://code.wireshark.org/review/26577
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  746410f   QUIC: fix decryption and PKN dissection with random access
    adds  184b943   QUIC: fully fix random access decryption, improve error messages


Summary of changes:
 epan/dissectors/packet-quic.c | 259 +++++++++++++++++++-----------------------
 1 file changed, 115 insertions(+), 144 deletions(-)