Wireshark-commits: [Wireshark-commits] master 746410f: QUIC: fix decryption and PKN dissection with
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 21 Mar 2018 16:57:32 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=746410f70fcbb252db6d254a2873457d3820315e
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

746410f by Peter Wu (peter@xxxxxxxxxxxxx):

    QUIC: fix decryption and PKN dissection with random access
    
    Packet number (PKN) reconstruction must happen sequentially or the wrong
    value can be derived. A wrong packet number will also result in
    decryption value. Fix this by storing the full packet number per packet.
    
    Always display the full PKN field for use in a column. Improve tracking
    of the client and server side.
    
    Bug: 13881
    Change-Id: Ia386893e719411c21793aca509a6d07a06823e2e
    Reviewed-on: https://code.wireshark.org/review/26574
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  8ca1e35   QUIC: Add 1-RTT packet decryption (draft -09)
    adds  746410f   QUIC: fix decryption and PKN dissection with random access


Summary of changes:
 epan/dissectors/packet-quic.c | 166 ++++++++++++++++++++++++++----------------
 1 file changed, 102 insertions(+), 64 deletions(-)