Wireshark-commits: [Wireshark-commits] master 727c815: IPMI: Disable bus command dissection.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 22 Feb 2018 22:27:49 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=727c815ad2b22aeb183c40e8fa78c640cff56f99
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

727c815 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    IPMI: Disable bus command dissection.
    
    This dissector has had multiple, severe issues over the years. Disable
    bus command dissection by default. Add a warning about re-enabling it.
    
    Change-Id: I9f71fafe2961f349825e6eda1f351025e00be182
    Reviewed-on: https://code.wireshark.org/review/26008
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  f14f76d   dmp: Allow multiple SecurityCategories again
    adds  727c815   IPMI: Disable bus command dissection.


Summary of changes:
 epan/dissectors/packet-ipmi.c | 29 ++++++++++++++++++++++-------
 1 file changed, 22 insertions(+), 7 deletions(-)