Wireshark-commits: [Wireshark-commits] master f14f76d: dmp: Allow multiple SecurityCategories again
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 22 Feb 2018 22:25:41 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f14f76d12a3107f0a89884f084640925ba033b28
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f14f76d by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    dmp: Allow multiple SecurityCategories again
    
    A Security Classification in DMP may have multiple Security Categories
    so don't restrict this to only one.  Add a arbitrary limit of 255 to
    avoid a long dissector loop in malformed packets.
    
    This fixes a bug introduced in g85bbda51.
    
    Bug: 14408
    Change-Id: I48e7a61a097c58dfcf21e9c9ed3147cf1573dae6
    Reviewed-on: https://code.wireshark.org/review/26011
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  380381c   TWAMP: Reassemble only the Server-Greeting message
    adds  f14f76d   dmp: Allow multiple SecurityCategories again


Summary of changes:
 epan/dissectors/packet-dmp.c | 36 ++++++++++++++++++++++++++----------
 1 file changed, 26 insertions(+), 10 deletions(-)