Wireshark-commits: [Wireshark-commits] master fff930d: Qt: do not expand collapsed trees when switc
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 31 Mar 2017 09:45:22 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fff930d3939c21a1ed988ef9014c32f75739ea7c
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

fff930d by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: do not expand collapsed trees when switching packets
    
    Scenario: user selects a field, collapsed tha parent tree and selects
    the next packet. Before this patch, the tree would be expanded again,
    selecting the child. After this patch, the tree will not be expanded,
    instead selecting the tree node that got collapsed.
    
    Change-Id: I7968fca1056a937cf3b399afb6f3089c2d199067
    Reviewed-on: https://code.wireshark.org/review/20801
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Graham Bloice <graham.bloice@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  641a48e   checkAPIs: improve trailing item suggestion for XXX_string
    adds  fff930d   Qt: do not expand collapsed trees when switching packets


Summary of changes:
 ui/qt/proto_tree.cpp |   11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)