Wireshark · Wireshark-commits: [Wireshark-commits] master 641a48e: checkAPIs: improve trailing item suggestion for XXX_string

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=641a48ec68778a5eaed82e436c09642e9ef1f911
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

641a48e by Peter Wu (peter@xxxxxxxxxxxxx):

    checkAPIs: improve trailing item suggestion for XXX_string
    
    Tighten the check (do not just check for "0,NULL}};" but also
    "{0,NULL}};" in case someone decides to use "{0x10,NULL}};" as trailing
    item. Improve the suggestion, "{NULL,NULL}" is better for string_string
    than "{0,NULL}".
    
    For now treat 0 the same as NULL since files like packet-fix.h would
    need editing otherwise. Accept octal notation for value_string since
    packet-nfs.c uses this in nfs2_mode_names.
    
    Change-Id: Ic507dbd8b07f3ae062b3f0310aa3398115d54273
    Reviewed-on: https://code.wireshark.org/review/20796
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  0896352   Fix typo.
    adds  641a48e   checkAPIs: improve trailing item suggestion for XXX_string


Summary of changes:
 tools/checkAPIs.pl |   29 +++++++++++++++++++++++++----
 1 file changed, 25 insertions(+), 4 deletions(-)