Wireshark-commits: [Wireshark-commits] master 0369b50: Fix processing of AMQP 0-10 arrays, maps, an
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 29 Mar 2017 16:28:52 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0369b504d3bc3ef791e8429e1218177c2d2fc97d
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0369b50 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix processing of AMQP 0-10 arrays, maps, and conneciton locales.
    
    You can't call proto_tree_add_XXX routines on a proto_item * that hasn't
    been given a subtree with proto_item_add_subtree().  Fix that.
    
    The packet offset for a FT_UINT_STRING is a pointer to the first byte of
    the *length*, not to the first byte *after* the length.
    
    Properly pluralize "entry".
    
    Change-Id: I7f2a55eaad850e3e52e62eb061e0444d176c593a
    Reviewed-on: https://code.wireshark.org/review/20785
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  601fe5e   Qt: propagate selection from main screen to dialog
    adds  0369b50   Fix processing of AMQP 0-10 arrays, maps, and conneciton locales.


Summary of changes:
 epan/dissectors/packet-amqp.c |   11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)