Wireshark · Wireshark-commits: [Wireshark-commits] master 601fe5e: Qt: propagate selection from main screen to dialog

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=601fe5e3516b67e709628f9c4a4fa2c2f8918041
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

601fe5e by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: propagate selection from main screen to dialog
    
    Ensure that the selection in main screen is updated on refreshing
    interfaces (InterfaceFrame::interfaceListChanged). Add additional
    patches to ensure that selection changes from the main screen propagate
    to the dialog and be careful to avoid infinite recursions.
    
    Life of a signal for InterfaceFrame:
    
        ui->interfaceTree->selectionModel emits selectionChanged
        -> slot InterfaceFrame::interfaceTreeSelectionChanged
          -> emits InterfaceFrame::itemSelectionChanged
            -> slot MainWelcome::interfaceSelected
               -> emits MainWelcome::interfacesChanged
                  -> slot CaptureInterfacesDialog::interfaceSelected
                     (updats dialog selection)
    
    Life of a signal for CaptureInterfacesDialog:
    
        ui->interfaceTree emits itemSelectionChanged
        -> slot CaptureInterfacesDialog::interfaceSelected
           (emission of next signal because sender is ui->interfaceTree)
           -> emits CaptureInterfacesDialog::interfacesChanged
              -> slot InterfaceFrame::updateSelectedInterfaces
                 (updates main screen selection)
    
    This should probably be updated to model/view with shared selection
    model in the future.
    
    Change-Id: Ibb32c201a92bd2f1310523b3e6e63b03209c9ce4
    Reviewed-on: https://code.wireshark.org/review/20487
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  5eaa9e7   packet-icmpv6.c: Fix some value_strings
    adds  601fe5e   Qt: propagate selection from main screen to dialog


Summary of changes:
 ui/qt/capture_interfaces_dialog.cpp |   38 ++++++++++++++++++++++++++++++++---
 ui/qt/capture_interfaces_dialog.h   |    1 +
 ui/qt/interface_frame.cpp           |    2 ++
 ui/qt/main_welcome.cpp              |    3 +++
 ui/qt/main_welcome.h                |    1 +
 ui/qt/main_window_slots.cpp         |    3 +++
 6 files changed, 45 insertions(+), 3 deletions(-)