Wireshark-commits: [Wireshark-commits] master 2dbde83: CIP Motion: Minor updates
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 24 Mar 2017 04:38:47 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2dbde83ee56dd2879cb7076ec46f5b432c8f3d69
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2dbde83 by D. Ulis (daulis0@xxxxxxxxx):

    CIP Motion: Minor updates
    
    1. Change protocol name from "Motion" to "CIP Motion". This now matches "CIP Safety" I/O.
    2. Print out unparsed data as bytes.
    3. Remove if(tree) check
    4. Clean up the parsing to be a little more consistent, and in packet byte order.
    
    Change-Id: I5c28522da7991852b708d825a349badc036b4b8d
    Reviewed-on: https://code.wireshark.org/review/20673
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  3ddaa5e   BGP: Decode Route Distinguisher in VPN Flow Specification
    adds  2dbde83   CIP Motion: Minor updates


Summary of changes:
 epan/dissectors/packet-cipmotion.c |  139 ++++++++++++++++++------------------
 1 file changed, 71 insertions(+), 68 deletions(-)