Wireshark-commits: [Wireshark-commits] master 3ddaa5e: BGP: Decode Route Distinguisher in VPN Flow
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 24 Mar 2017 04:36:16 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3ddaa5ebc93ed6022dbb552448a5508a907f51dc
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3ddaa5e by IWASE Yusuke (iwase.yusuke0@xxxxxxxxx):

    BGP: Decode Route Distinguisher in VPN Flow Specification
    
    RFC5575 says Route Distinguisher is inserted between "length" and "NLRI
    value" fields when the BGP NLRI type is VPNv4 Flow Spec (AFI=1,
    SAFI=134) and this is the same for VPNv6 and L2VPN.
    
    This patch fixes the BGP dissector to decode the missing Route
    Distinguisher field in Flow Spec NLRI decoder.
    
    Change-Id: Ib45d96bb399b80be69ca70ea552d2c07b07a9782
    Signed-off-by: IWASE Yusuke <iwase.yusuke0@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/20653
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  383ba15   Clean up updateRemoteInterfaceList a bit more.
    adds  3ddaa5e   BGP: Decode Route Distinguisher in VPN Flow Specification


Summary of changes:
 epan/dissectors/packet-bgp.c |   75 ++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 72 insertions(+), 3 deletions(-)