Wireshark-commits: [Wireshark-commits] master 2d0ae39: ftypes: move get_value_ptr into the union
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 20 Mar 2017 17:01:39 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2d0ae39bd6708f00d2b6fb357c1146dcf4d3dbb8
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2d0ae39 by Martin Kaiser (wireshark@xxxxxxxxx):

    ftypes: move get_value_ptr into the union
    
    Delete get_value_ptr from struct _ftype_t, make it
    part of the get_value union.
    
    Change-Id: I947331069662a7043bd838e622d286629cc7be9a
    Reviewed-on: https://code.wireshark.org/review/20647
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  45b8a1e   MIPv6: Bugfix proto_tree_add_item_ret_uint usage.
    adds  2d0ae39   ftypes: move get_value_ptr into the union


Summary of changes:
 epan/ftypes/ftype-bytes.c            |   36 ++++++++---------------------
 epan/ftypes/ftype-double.c           |    4 ----
 epan/ftypes/ftype-guid.c             |    4 +---
 epan/ftypes/ftype-ieee-11073-float.c |    4 ----
 epan/ftypes/ftype-integer.c          |   42 ----------------------------------
 epan/ftypes/ftype-ipv4.c             |    4 +---
 epan/ftypes/ftype-ipv6.c             |    4 +---
 epan/ftypes/ftype-none.c             |    2 --
 epan/ftypes/ftype-pcre.c             |    4 +---
 epan/ftypes/ftype-protocol.c         |    4 +---
 epan/ftypes/ftype-string.c           |   16 ++++---------
 epan/ftypes/ftype-time.c             |    8 ++-----
 epan/ftypes/ftypes-int.h             |    4 +---
 epan/ftypes/ftypes.c                 |   21 +++++++++++++++--
 14 files changed, 40 insertions(+), 117 deletions(-)