Wireshark-commits: [Wireshark-commits] master 45b8a1e: MIPv6: Bugfix proto_tree_add_item_ret_uint u
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 20 Mar 2017 15:44:32 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=45b8a1e7ea18d62f78aa6f7812d91a576811ae72
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

45b8a1e by Michael Mann (mmann78@xxxxxxxxxxxx):

    MIPv6: Bugfix proto_tree_add_item_ret_uint usage.
    
    hf_mip6_ipv4ha_ha field is an FT_IPv4 type, so proto_tree_add_item_ret_uint can't be used.
    
    Also correct option tree display noticed while debugging above issue.
    
    Bug: 13499
    Change-Id: I6da281567f47d08864575e41fa2a29347d55613a
    Reviewed-on: https://code.wireshark.org/review/20646
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  e6525ab   packet-nvme-rdma: Add support to dissect send with invalidate
    adds  45b8a1e   MIPv6: Bugfix proto_tree_add_item_ret_uint usage.


Summary of changes:
 epan/dissectors/packet-mip6.c |   14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)