Wireshark-commits: [Wireshark-commits] master e94bd9b: ftypes: move get_value_sinteger into the uni
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 19 Mar 2017 22:55:28 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e94bd9b4eeeb882c83b0c1624e9f63b77e9c3d5d
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e94bd9b by Martin Kaiser (wireshark@xxxxxxxxx):

    ftypes: move get_value_sinteger into the union
    
    Delete get_value_sinteger from struct _ftype_t, make it
    part of the get_value union.
    
    Change-Id: I3127252cafc62389ce426639992f1d59f7ac9731
    Reviewed-on: https://code.wireshark.org/review/20637
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  2a34738   eth: remove unnecessary NULL checks
    adds  e94bd9b   ftypes: move get_value_sinteger into the union


Summary of changes:
 epan/ftypes/ftype-bytes.c            |    9 ---------
 epan/ftypes/ftype-double.c           |    2 --
 epan/ftypes/ftype-guid.c             |    1 -
 epan/ftypes/ftype-ieee-11073-float.c |    2 --
 epan/ftypes/ftype-integer.c          |   29 ++++-------------------------
 epan/ftypes/ftype-ipv4.c             |    1 -
 epan/ftypes/ftype-ipv6.c             |    1 -
 epan/ftypes/ftype-none.c             |    1 -
 epan/ftypes/ftype-pcre.c             |    1 -
 epan/ftypes/ftype-protocol.c         |    1 -
 epan/ftypes/ftype-string.c           |    4 ----
 epan/ftypes/ftype-time.c             |    2 --
 epan/ftypes/ftypes-int.h             |    2 +-
 epan/ftypes/ftypes.c                 |    8 ++++++--
 14 files changed, 11 insertions(+), 53 deletions(-)