Wireshark-commits: [Wireshark-commits] master 2a34738: eth: remove unnecessary NULL checks
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 19 Mar 2017 22:54:15 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2a3473820da5834b7d3732a3c6e314245839a673
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2a34738 by Martin Kaiser (wireshark@xxxxxxxxx):

    eth: remove unnecessary NULL checks
    
    We may safely call proto_item_add_subtree() when the item is NULL.
    Make sure that expert info are not filtered out by a NULL check.
    
    Change-Id: I4516cd750c9b0b568c8de9adaad757d0ea769ad6
    Reviewed-on: https://code.wireshark.org/review/20639
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  401f901   TLS13: update pre_shared_key lengths for draft -19
    adds  2a34738   eth: remove unnecessary NULL checks


Summary of changes:
 epan/dissectors/packet-eth.c |   36 +++++++++++++-----------------------
 1 file changed, 13 insertions(+), 23 deletions(-)