Wireshark-commits: [Wireshark-commits] master 528a3d3: proto: Check for empty protocol->fields
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 9 Mar 2017 08:59:12 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=528a3d31ff1861d5445ee649752876e8bed82270
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

528a3d3 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    proto: Check for empty protocol->fields
    
    In proto_get_first_protocol_field() we must check for an empty
    protocol->fields because Lua scripts may have protocols without
    fields and g_ptr_array_index() does not perform bounds checking
    on the given index.
    
    Bug: 13223
    Change-Id: Ib2f6286d0799541243450348dcf345a965b2825c
    Reviewed-on: https://code.wireshark.org/review/20455
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  540b555   Introduce "bytes_string" type, similar to "value_string"
    adds  528a3d3   proto: Check for empty protocol->fields


Summary of changes:
 epan/proto.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)