Wireshark · Wireshark-commits: [Wireshark-commits] master 540b555: Introduce "bytes_string" type, similar to "value_string"

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=540b5557291ad0960ce566adc3f24100aac946de
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

540b555 by Peter Wu (peter@xxxxxxxxxxxxx):

    Introduce "bytes_string" type, similar to "value_string"
    
    In order to map arbitrary byte buffers to strings, introduce a new
    "bytes_string" type. Since "bytes_to_str" is already used for other
    purposes, name the generic function "bytesval_to_str" instead similar to
    the name( "val_to_str").
    
    Accept "size_t" as length parameter since this is what is returned by
    the "sizeof" operator. Do not add a "try_bytesval_to_str_idx" variant
    since this pattern is not needed for now. Add a variant to match the
    prefix since this is currently expected by the ISAKMP dissector.
    
    Change-Id: I6d790325e85d9fb1384330f28a8c36e2057fdf30
    Reviewed-on: https://code.wireshark.org/review/20386
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  2b06c17   ubertooth: fix this statement may fall through [-Werror=implicit-fallthrough=] found by gcc7
    adds  540b555   Introduce "bytes_string" type, similar to "value_string"


Summary of changes:
 debian/libwireshark0.symbols    |    4 ++
 epan/dissectors/packet-isakmp.c |   57 +----------------------------
 epan/value_string.c             |   77 +++++++++++++++++++++++++++++++++++++++
 epan/value_string.h             |   26 +++++++++++++
 4 files changed, 109 insertions(+), 55 deletions(-)