Wireshark-commits: [Wireshark-commits] master 8f35d6f: Qt: allow Packet Bytes view to be shrinked
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 3 Mar 2017 04:58:38 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8f35d6ff900120afe53ffaa9284ed86b5db9614a
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8f35d6f by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: allow Packet Bytes view to be shrinked
    
    Even if a packet has only one or two lines for the byte view, Qt
    autoresizing insists to require a minimum of 5.5 lines (or 7.5 lines for
    packets without multiple data sources). Remove this artificial
    requirement and allow the packet bytes view to be resized to show
    nothing (except for possible data sources tabs).
    
    This makes it easier to fit more packets and details for screenshots.
    
    Change-Id: I3ea997b9effa8292b396dc2ceb2ab1c35cead410
    Reviewed-on: https://code.wireshark.org/review/20342
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  a9ec1e4   Squelch a warning from VS Code Analysis.
    adds  8f35d6f   Qt: allow Packet Bytes view to be shrinked


Summary of changes:
 ui/qt/byte_view_text.cpp |    6 ++++++
 ui/qt/byte_view_text.h   |    1 +
 2 files changed, 7 insertions(+)