Wireshark-commits: [Wireshark-commits] master a9ec1e4: Squelch a warning from VS Code Analysis.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 3 Mar 2017 02:55:30 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a9ec1e41b19abd9da62f15ffbd94db3dbc4a3d9f
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a9ec1e4 by Guy Harris (guy@xxxxxxxxxxxx):

    Squelch a warning from VS Code Analysis.
    
    It warns that a 32-bit value is being shifted left and then converted to
    a 64-bit type; presumably it means "this might overflow and not give you
    the result you expect".  That's unlikely to be the case here, as few
    UN*X file systems have a recommended I/O block size > 2^30, but we might
    as well throw in a cast so the convert-to-a-64-bit-type is done first.
    
    Change-Id: Id6ab11d750d5cf4cc03d060d63edc01b66cd179d
    Reviewed-on: https://code.wireshark.org/review/20352
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  300f474   Fix compilation with old libcrypt versions.
    adds  a9ec1e4   Squelch a warning from VS Code Analysis.


Summary of changes:
 wiretap/file_wrappers.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)