Wireshark-commits: [Wireshark-commits] master 2275e02: Revert "Simplify val_to_str[_ext] implementa
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 11 May 2016 04:22:43 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2275e0273091314b38ed411a8cae39ed877f5bec
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2275e02 by Guy Harris (guy@xxxxxxxxxxxx):

    Revert "Simplify val_to_str[_ext] implementation."
    
    This reverts commit 1d0a97493280fd79d00e85a0971b3842d7f00e5e.
    
    This appears to be causing a crash - and the code in val_to_str() isn't just a copy of the code in val_to_str_wmem(), as it doesn't do a wmem allocation if try_val_to_str(), which *doesn't* use wmem, succeeds.
    
    Change-Id: I40e9e8b4ed0a1c66e20ab4bd827ac51c3fac85ff
    Reviewed-on: https://code.wireshark.org/review/15351
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  1d0a974   Simplify val_to_str[_ext] implementation.
    adds  2275e02   Revert "Simplify val_to_str[_ext] implementation."


Summary of changes:
 epan/value_string.c |   20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)