Wireshark-commits: [Wireshark-commits] master 1d0a974: Simplify val_to_str[_ext] implementation.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 11 May 2016 03:17:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1d0a97493280fd79d00e85a0971b3842d7f00e5e
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1d0a974 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Simplify val_to_str[_ext] implementation.
    
    All val_to_str API use wmem, so just call the wmem function version
    passing packet_scope instead of copying it.
    
    Change-Id: Ib58b6b702fbaf5a81cc445bd01ef1a523774be6e
    Reviewed-on: https://code.wireshark.org/review/15348
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  9d08ef3   Remove strcpy from wmem_strbuf.c
    adds  1d0a974   Simplify val_to_str[_ext] implementation.


Summary of changes:
 epan/value_string.c |   20 ++------------------
 1 file changed, 2 insertions(+), 18 deletions(-)