Wireshark · Wireshark-commits: [Wireshark-commits] master 4a79cf2: Switch from QLibrary to ws_load_library.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4a79cf2e1ab056faaddd252aa56520435b318a56
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4a79cf2 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Switch from QLibrary to ws_load_library.
    
    From the comments in qlibrary_win.cpp:
    
    // We make the following attempts at locating the library:
    [ ... ]
    // Windows
    // if (absolute)
    //     fileName
    //     fileName + ".dll"
    // else
    //     fileName + ".dll"
    //     fileName
    
    We were passing "riched20.dll" to QLibrary, which meant that it searched
    for "riched20.dll.dll" first.
    
    Switch to ws_load_library, which we use elsewhere and which has much
    safer default behavior.
    
    Change-Id: Ic8f0cf5686c9b1856d37e76be4404d6236c076e5
    Reviewed-on: https://code.wireshark.org/review/13607
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  057b8d7   plugins: do not import symbols globally
    adds  4a79cf2   Switch from QLibrary to ws_load_library.


Summary of changes:
 ui/gtk/main.c                   |    2 +-
 ui/qt/wireshark_application.cpp |   17 ++++-------------
 2 files changed, 5 insertions(+), 14 deletions(-)