Wireshark-commits: [Wireshark-commits] master 057b8d7: plugins: do not import symbols globally
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 31 Jan 2016 13:31:40 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=057b8d7dde25f638a13de45d8e3fcb51da7fb28d
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

057b8d7 by Peter Wu (peter@xxxxxxxxxxxxx):

    plugins: do not import symbols globally
    
    Clang's ASAN reported an ODR violation when plugins were loaded. Sure
    enough, symbols did actually get loaded twice:
    
        ==5898==ERROR: AddressSanitizer: odr-violation (0x7fffd95a35e0):
          [1] size=7 'version' plugins/mate/plugin.c:19:31
          [2] size=6 'version' plugins/opcua/plugin.c:19:31
    
    After this change, plugins cannot insert new symbols in the global
    namespace.
    
    Change-Id: Ib11f7263e9c586f8e7c1f8f5fb239b20d46ddd2f
    Reviewed-on: https://code.wireshark.org/review/13260
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  2bf715d   lemon: fix leak.
    adds  057b8d7   plugins: do not import symbols globally


Summary of changes:
 tools/test-common.sh |    2 +-
 wsutil/plugins.c     |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)