Wireshark-commits: [Wireshark-commits] master 7fdf4ce: Qt: Update display filter bookmarks when lis
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 28 Jan 2016 18:28:42 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7fdf4ceaa6d5bacb69165adc2e7c7f56d696a685
Submitter: Stig Bjørlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7fdf4ce by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Update display filter bookmarks when list changed
    
    Recreate the display filter bookmarks menu only when the list
    has changed, not every time the display filter changes.
    
    The list changes when removing an entry from the menu and
    when changing the list in the "Manage Display Filters" dialog.
    
    Save the list when removing an entry from the menu.
    
    Change-Id: Icd08e0a80085cca55c0e63177d45abe4902c7c3e
    Reviewed-on: https://code.wireshark.org/review/13567
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  265a41e   autotools: Don't use "user variables" to set build flags
    adds  7fdf4ce   Qt: Update display filter bookmarks when list changed


Summary of changes:
 ui/qt/display_filter_edit.cpp   |   92 ++++++++++++++++++++++++++++-----------
 ui/qt/display_filter_edit.h     |    3 ++
 ui/qt/filter_dialog.cpp         |    4 ++
 ui/qt/wireshark_application.cpp |    4 ++
 ui/qt/wireshark_application.h   |    2 +
 5 files changed, 79 insertions(+), 26 deletions(-)