Wireshark-commits: [Wireshark-commits] master 265a41e: autotools: Don't use "user variables" to set
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=265a41e14da6b3ebf1e49e726eee62d1372110bf
Submitter: João Valverde (j@xxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
265a41e by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):
autotools: Don't use "user variables" to set build flags
GNU coding standards recommend against it and automake is designed
around it.
This allows overriding the global build flags using AM_CFLAGS, etc.,
or per object flags, something that is difficult or impossible currently
because of automake precedence rules.
Change-Id: I3f1ea12e560af5a46b2f04b342b1882bbf123f12
Reviewed-on: https://code.wireshark.org/review/13455
Petri-Dish: João Valverde <j@xxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: João Valverde <j@xxxxxx>
Actions performed:
from 97a1a50 extcap: Cleanup complex types and add save option
adds 265a41e autotools: Don't use "user variables" to set build flags
Summary of changes:
Makefile.am | 49 ++-------
Makefile.am.inc | 30 ++++-
acinclude.m4 | 214 ++++++++++++++++++------------------
capchild/Makefile.am | 13 +--
caputils/Makefile.am | 13 +--
codecs/Makefile.am | 11 +-
configure.ac | 140 +++++++++++------------
echld/Makefile.am | 17 +--
epan/Makefile.am | 34 ++----
epan/compress/Makefile.am | 8 +-
epan/crypt/Makefile.am | 8 +-
epan/dfilter/Makefile.am | 23 ++--
epan/dissectors/Makefile.am | 14 +--
epan/dissectors/dcerpc/Makefile.am | 1 +
epan/ftypes/Makefile.am | 9 +-
epan/nghttp2/Makefile.am | 9 +-
epan/wmem/Makefile.am | 9 +-
epan/wslua/Makefile.am | 6 +-
plugins/docsis/Makefile.am | 9 +-
plugins/ethercat/Makefile.am | 9 +-
plugins/gryphon/Makefile.am | 9 +-
plugins/irda/Makefile.am | 9 +-
plugins/m2m/Makefile.am | 9 +-
plugins/mate/Makefile.am | 15 +--
plugins/opcua/Makefile.am | 9 +-
plugins/profinet/Makefile.am | 9 +-
plugins/stats_tree/Makefile.am | 9 +-
plugins/tpg/Makefile.am | 7 +-
plugins/unistim/Makefile.am | 9 +-
plugins/wimax/Makefile.am | 9 +-
plugins/wimaxasncp/Makefile.am | 9 +-
plugins/wimaxmacphy/Makefile.am | 9 +-
ui/Makefile.am | 17 +--
ui/cli/Makefile.am | 13 +--
ui/gtk/Makefile.am | 17 +--
ui/qt/Makefile.am | 16 +--
wiretap/Makefile.am | 17 +--
wsutil/Makefile.am | 21 +---
38 files changed, 302 insertions(+), 537 deletions(-)
