Wireshark-commits: [Wireshark-commits] master 54e3b32: Don't treat Visual Studio specially for link
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 27 Jan 2016 05:25:00 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=54e3b32027f1b28cc9871b5ff35c358eaf8cd05f
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

54e3b32 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't treat Visual Studio specially for linker flags.
    
    Have CHECK_C_LINKER_FLAG pass /WX to the linker if we're using MSVC, to
    force the link to fail if the linker doesn't recognize the flag.
    
    Add flags to WIRESHARK_LD_FLAGS even with MSVC; let CHECK_C_LINKER_FLAG
    figure out whether the flag should be used.
    
    While we're at it, fix CHECK_C_LINKER_FLAG to save and restore
    CMAKE_REQUIRED_LIBRARIES.
    
    Change-Id: I7f73b4cc3a28eb14e46c2e1e9ad69f5303754f01
    Reviewed-on: https://code.wireshark.org/review/13558
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  59bdb4b   CIP: Add support for all defined segment types
    adds  54e3b32   Don't treat Visual Studio specially for linker flags.


Summary of changes:
 CMakeLists.txt                       |   40 ++++++++++++----------------------
 cmake/modules/CheckCLinkerFlag.cmake |   16 +++++++++++---
 2 files changed, 27 insertions(+), 29 deletions(-)