Wireshark · Wireshark-commits: [Wireshark-commits] master 59bdb4b: CIP: Add support for all defined segment types

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=59bdb4bcb6fa8deea4bdd0cbf1940acc11ef5f4d
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

59bdb4b by D. Ulis (daulis0@xxxxxxxxx):

    CIP: Add support for all defined segment types
    
    Add support for the following segment types:
    1. Port: Extended
    2. Logical: Service ID
    3. Logical: Extended
    4. Symbolic: ASCII, Extended String, including: Double-byte, Triple-byte, Numeric (USINT, UINT, UDINT)
    5. Network: Extended
    6. Network: Production Inhibit Time in Microseconds
    
    Bug: 12049
    Change-Id: I31b269c28c0101205cbc02f858de47106b9e7373
    Reviewed-on: https://code.wireshark.org/review/13552
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  3cecda0   Explain why we're still checking for MSVC.
    adds  59bdb4b   CIP: Add support for all defined segment types


Summary of changes:
 epan/dissectors/packet-cip.c |  591 ++++++++++++++++++++++++++++++++++++++----
 epan/dissectors/packet-cip.h |   13 +-
 2 files changed, 546 insertions(+), 58 deletions(-)