Wireshark · Wireshark-commits: [Wireshark-commits] master 0ff957a: dns, spdy, ssl-utils: fix export PDU

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0ff957aedec43e0ba3c0e7f54b9de14d54da86ec
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0ff957a by Peter Wu (peter@xxxxxxxxxxxxx):

    dns,spdy,ssl-utils: fix export PDU
    
    Dissectors registered with SSL must be registered for Export PDU to
    work properly. Otherwise the dissector name could be NULL, resulting
    in a capture file that cannot properly be dissected.
    
    Add an assertion to ssl-utils to catch this situation. Note that this
    results in an "wmem_alloc: assertion failed: (allocator->in_scope)"
    report because these functions are possibly called in the protocol
    handoff routines... Can be fixed later.
    
    The DNS dissector is fixed by merging the UDP/TCP dissectors into a
    single dns handle which recognizes TCP and then assumes the length
    prefix if TCP.
    
    Change-Id: If73b9b09a4682d66fb8fa026c42a3475648f9bf1
    Reviewed-on: https://code.wireshark.org/review/13194
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  0f5bed3   ssl: fix RSA key matching with Client certs
    adds  0ff957a   dns,spdy,ssl-utils: fix export PDU


Summary of changes:
 epan/dissectors/packet-dns.c       |   28 +++++++++++-----------------
 epan/dissectors/packet-spdy.c      |    5 +----
 epan/dissectors/packet-ssl-utils.c |    3 +++
 3 files changed, 15 insertions(+), 21 deletions(-)