Wireshark-commits: [Wireshark-commits] master-2.0 721f0f3: ssl: fix RSA key matching with Client ce
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 25 Jan 2016 21:06:18 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=721f0f3613f3d0073edc3b2e4fb790e6339cdbbf
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

721f0f3 by Peter Wu (peter@xxxxxxxxxxxxx):

    ssl: fix RSA key matching with Client certs
    
    Avoid a RSA private key lookup for client certificates, the RSA private
    key is only valid for the server certificate. The lookup based on the
    client cert resulted in overwriting the server match.
    
    Bug: 12042
    Change-Id: I60aa79f8f2b941bfde032e20ab11446ae4e6c81b
    Reviewed-on: https://code.wireshark.org/review/13530
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit 0f5bed39fe90659615b192d9a88d7d206d349fff)
    Reviewed-on: https://code.wireshark.org/review/13534
    

Actions performed:

    from  e6a9011   phdr->pkt_encap and phdr->pkt_tsprec need to be set for seek-read too.
    adds  721f0f3   ssl: fix RSA key matching with Client certs


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)