Wireshark-commits: [Wireshark-commits] master 6425ba9: IEEE802.11: fix EAPOL key frame detection
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 16 Jan 2016 11:39:01 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6425ba961dc481439c2856052e6e831fa5dc426f
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6425ba9 by Alexander Wetzel (alexander.wetzel@xxxxxx):

    IEEE802.11: fix EAPOL key frame detection
    
    Use eapol key data length to differentiate between #2 and #4.
    This should work around ieee802.11 client implementation errors.
    
    Windows is setting the Secure Bit on #2 when rekeying and Bug 11994
    has a sample capture with the Nonce set in #4 and are so both
    violating the spec.
    
    Bug: 11994
    Change-Id: Ia9e9c68d08dae042cfa7fd9517892db211b0a00f
    Reviewed-on: https://code.wireshark.org/review/13299
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  e3ab748   extcap: Code cleanup
    adds  6425ba9   IEEE802.11: fix EAPOL key frame detection


Summary of changes:
 epan/crypt/airpdcap.c              |    6 ++----
 epan/crypt/airpdcap_user.h         |   11 -----------
 epan/dissectors/packet-ieee80211.c |   20 +++++++++-----------
 3 files changed, 11 insertions(+), 26 deletions(-)