Wireshark-commits: [Wireshark-commits] master e3ab748: extcap: Code cleanup
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 16 Jan 2016 08:50:43 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e3ab748b7de499bc2c99e25b1067b5159235ec74
Submitter: Roland Knall (rknall@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e3ab748 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    extcap: Code cleanup
    
    Rewrote to avoid unneeded g_strdup/g_free constructs, made some
    arguments const, simplified some code and fixed some whitespace.
    
    Plugged a memory leak in extcap_free_info().
    
    Change-Id: I0bfcd86e6464d8bc592329b05dc994191a430096
    Reviewed-on: https://code.wireshark.org/review/13306
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  8f6da81   Revert "Don't use the printf command; it's not guaranteed to be there."
    adds  e3ab748   extcap: Code cleanup


Summary of changes:
 extcap.c |   75 ++++++++++++++++++++++----------------------------------------
 1 file changed, 26 insertions(+), 49 deletions(-)